Feat/account linking improvements#2506
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
| return result; | ||
| } catch (err) { | ||
| setError(err as Web3AuthError); | ||
| throw err; |
Member
There was a problem hiding this comment.
you never throw error in hooks
| } catch (err) { | ||
| log.error("Error linking account", err); | ||
| error.value = err as Web3AuthError; | ||
| throw err; |
Member
There was a problem hiding this comment.
never throw error in composables
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 6c19b6d. Configure here.
chaitanyapotti
approved these changes
May 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Jira Link
Description
Miscellaneous improvements on Account Linking feature:
LinkedAccountslist (Please refer to this commit f593f50)projectConfigfor linked injected wallets rehydrationHow has this been tested?
Screenshots (if appropriate)
Types of changes
Checklist
Note
Medium Risk
Touches session rehydration, Wagmi binding, and wallet disconnect on link failure—user-visible connection/account-switch behavior, though changes are mostly defensive with new test coverage.
Overview
This PR tightens account linking end-to-end:
AccountLinkingErrorand helpers (formatAccountLinkingErrorMessage,getAccountLinkingRequestError) move into@web3auth/no-modal/account-linking, with richer Citadel/API failures (e.g. 409 already registered) and consistent modal error text. The modal cachesprojectConfigon init for linked-wallet rehydration; core rehydrates linked wallets, emitsCONNECTION_UPDATED, and disconnects the linking wallet after a failed link.Linked account lists from AUTH now filter duplicate primaries for other chain namespaces and hide
account_abstractionrows. MetaMask maps user rejections toWalletOperationsError.userRejectedand avoids spurious disconnects when not connected.Wagmi (React/Vue, modal + no-modal) no longer gates binding on the primary connector name; it syncs on provider +
connectorNameand skips reconnect when already bound—fixing rehydration for linked EVM accounts. Lockfiles bump @metamask/connect-* packages; new tests cover account-linking errors/REST.Reviewed by Cursor Bugbot for commit f4de37f. Bugbot is set up for automated code reviews on this repo. Configure here.